Use POSIX -u instead of GNU --undefined for zig linker support#236
Merged
Shnatsel merged 1 commit intorust-secure-code:masterfrom Mar 3, 2026
Merged
Use POSIX -u instead of GNU --undefined for zig linker support#236Shnatsel merged 1 commit intorust-secure-code:masterfrom
-u instead of GNU --undefined for zig linker support#236Shnatsel merged 1 commit intorust-secure-code:masterfrom
Conversation
Member
|
Oh, it would be great if this was all I had to do to be compatible with zig! Fingers crossed |
Shnatsel
approved these changes
Mar 3, 2026
Member
Shnatsel
left a comment
Shnatsel
left a comment
There was a problem hiding this comment.
LTO tests pass on CI, and for me locally with mold and lld. Looks great!
Not sure why this is a draft, but I'm happy to merge whenever you're ready.
Contributor
Author
|
I just wanted to see if CI passed before marking it as ready for review :) I tested this with zig downstream in uv's Dockerfile and it seems to be working great. |
zanieb
added a commit
to astral-sh/uv
that referenced
this pull request
Mar 3, 2026
Adds SBOM attestations https://docs.docker.com/build/metadata/attestations/sbom/ Requires rust-secure-code/cargo-auditable#236 for our uv binaries and their dependencies to be included in the SBOM You can inspect the SBOM with, e.g.: ``` docker buildx imagetools inspect ghcr.io/astral-sh/uv-dev:sha-ece6427 --format '{{json .SBOM}}' | jq docker buildx imagetools inspect ghcr.io/astral-sh/uv-dev:sha-ece6427-python3.9-trixie --format '{{json .SBOM}}' | jq ``` Also explicitly sets https://docs.docker.com/build/metadata/attestations/slsa-provenance/#max but there appears to be no change as all of the max SLSA data is already present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #179